🛡️ Sentinel: [CRITICAL] Fix arbitrary command execution via profile.bitcoin_cli#3
🛡️ Sentinel: [CRITICAL] Fix arbitrary command execution via profile.bitcoin_cli#3bitcoiner-dev wants to merge 2 commits intomasterfrom
Conversation
…itcoin_cli 🚨 Severity: CRITICAL 💡 Vulnerability: `run_bitcoin_cli` executed the `bitcoin_cli` command defined in a user-provided profile without strict validation, potentially allowing arbitrary command execution if the profile was tampered with or maliciously constructed. Also removed duplicate implementation from `src/wallet_service.rs` which increased attack surface. 🎯 Impact: A malicious profile could execute arbitrary binaries on the host system with the arguments intended for bitcoin-cli. 🔧 Fix: Centralized the command execution in `src/utils.rs` and added an allowlist check on the binary filename, restricting execution to only `bitcoin-cli` or `bitcoin-cli.exe`. ✅ Verification: Verify by configuring a profile with a `bitcoin_cli` value other than `bitcoin-cli` or `bitcoin-cli.exe` and attempting any command that uses `bitcoin-cli`. It should fail with a "security violation" error. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules bunch of tests failing, please check why and fix them |
The test failures are caused by missing external path dependencies ( |
…itcoin_cli 🚨 Severity: CRITICAL 💡 Vulnerability: `run_bitcoin_cli` executed the `bitcoin_cli` command defined in a user-provided profile without strict validation, potentially allowing arbitrary command execution if the profile was tampered with or maliciously constructed. Also removed duplicate implementation from `src/wallet_service.rs` which increased attack surface. 🎯 Impact: A malicious profile could execute arbitrary binaries on the host system with the arguments intended for bitcoin-cli. 🔧 Fix: Centralized the command execution in `src/utils.rs` and added an allowlist check on the binary filename, restricting execution to only `bitcoin-cli` or `bitcoin-cli.exe`. ✅ Verification: Verify by configuring a profile with a `bitcoin_cli` value other than `bitcoin-cli` or `bitcoin-cli.exe` and attempting any command that uses `bitcoin-cli`. It should fail with a "security violation" error. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability:
run_bitcoin_cliexecuted thebitcoin_clicommand defined in a user-provided profile without strict validation, potentially allowing arbitrary command execution if the profile was tampered with or maliciously constructed. Also removed duplicate implementation fromsrc/wallet_service.rswhich increased attack surface.🎯 Impact: A malicious profile could execute arbitrary binaries on the host system with the arguments intended for bitcoin-cli.
🔧 Fix: Centralized the command execution in
src/utils.rsand added an allowlist check on the binary filename, restricting execution to onlybitcoin-cliorbitcoin-cli.exe.✅ Verification: Verify by configuring a profile with a
bitcoin_clivalue other thanbitcoin-cliorbitcoin-cli.exeand attempting any command that usesbitcoin-cli. It should fail with a "security violation" error.PR created automatically by Jules for task 10406263415786431380 started by @bitcoiner-dev