Don't try to add empty attendee caladdress#273
Merged
sunkup merged 1 commit intoical4j-3to4from Apr 1, 2026
Merged
Conversation
sunkup
added
the
pr-bugfix
ArnyminerZ
approved these changes
Mar 31, 2026
sunkup
changed the title
sunkup
deleted the
211-jtx-board-npe-when-adding-non-email-address-attendee
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
The caladdress for attendees usually contains the email with "mailto" format. It is however optional for attendees and could be empty or null. We were parsing the nullable email caladdress value for attendees using
java.net.URI, which then threw. Adding a null-check solves the issue and not adding the caladress when it is not present is ok, since it's optional. We don't always have to infer it.I have not added a test for the modified method
addPropertieshere, since the JtxICalObject is due for refactoring to the new builder/handler pattern with better tests soon anyways.