Adding check for project-version-violations and report back#55
Adding check for project-version-violations and report back#55jmvanryn wants to merge 6 commits intoblackducksoftware:masterfrom jmvanryn:master
Conversation
|
|
||
| def get_project_violation_status(self, project_name, version): | ||
|
|
||
| project = self.get_project_by_name(project_name) |
There was a problem hiding this comment.
did you consider using self.get_project_version_by_name? would replace use of get_project_by_name and the subsequent code to retrieve the version if present, e.g. this method would then become,
def get_project_violation_status(self, project_name, version):
version = self.get_project_version_by_name(project_name, version)
if version:
return version.get('policyStatus', None)
else:
return "{}:{} not found".format(project_name, version)
or something along those lines?
There was a problem hiding this comment.
Ah, well I believe I was looking at it this way because it is a more precise error. If I remember get_project_version_by_name will return a non 200 on both missing projects or versions. and I wanted to tell my users what was missing the project or the version or if the server was just miss-behaving
|
Oh wow.. Just saw this... I'll go through them now.. |
The function was working fine until we updated the version to 56 and we are facing this error @gsnyder2007 can you please take a look and let us know what api we can use instead? |
bringing my fork up to date

No description provided.