ch32f1: Fixed hanging gdb load command for CH32F103C8T6 MCU's#2191
Merged
dragonmux merged 1 commit intoblackmagic-debug:mainfrom Feb 8, 2026
Merged
Conversation
dragonmux
approved these changes
Feb 8, 2026
Member
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging. Thank you for the contribution! You are indeed correct that check was supposed to loop while EOP is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
It looks like a bug did slip into the code during refactoring of file src/target/ch32f1.c (commit 85cade5).
Fix: Added missing logical not operator (!) to function ch32f1_flash_eop_wait().
Your checklist for this pull request
Closing issues