Skip to content

ch32f1: Fixed hanging gdb load command for CH32F103C8T6 MCU's#2191

Merged
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
lasutek:fix/ch32f1-missing-not-operator
Feb 8, 2026
Merged

ch32f1: Fixed hanging gdb load command for CH32F103C8T6 MCU's#2191
dragonmux merged 1 commit intoblackmagic-debug:mainfrom
lasutek:fix/ch32f1-missing-not-operator

Conversation

@lasutek
Copy link
Contributor

@lasutek lasutek commented Feb 8, 2026

Detailed description

It looks like a bug did slip into the code during refactoring of file src/target/ch32f1.c (commit 85cade5).

Fix: Added missing logical not operator (!) to function ch32f1_flash_eop_wait().

Your checklist for this pull request

Closing issues

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution! You are indeed correct that check was supposed to loop while EOP is not set.

@dragonmux dragonmux added this to the v2.1 release milestone Feb 8, 2026
@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression labels Feb 8, 2026
@dragonmux dragonmux merged commit dfb0173 into blackmagic-debug:main Feb 8, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bug Regression Bug caused by a regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants