Skip to content

Port comdb2db_get_dbhosts changes#5716

Merged
chands10 merged 1 commit intobloomberg:mainfrom
chands10:c21
Feb 25, 2026
Merged

Port comdb2db_get_dbhosts changes#5716
chands10 merged 1 commit intobloomberg:mainfrom
chands10:c21

Conversation

@chands10
Copy link
Copy Markdown
Contributor

@chands10 chands10 commented Feb 6, 2026

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
maxtable [core dumped]
insert_lots_ssl_generated
insert_lots
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
skipscan
sc_downgrade
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
@chands10
Copy link
Copy Markdown
Contributor Author

rebased

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
reco-ddlk-sql
lock_views
guid

@chands10
Copy link
Copy Markdown
Contributor Author

/adhoc-test lock_views guid

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

Copy link
Copy Markdown
Contributor

@mohitkhullar mohitkhullar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chands10
Copy link
Copy Markdown
Contributor Author

Thanks Mohit!!

@chands10 chands10 merged commit 0c8457d into bloomberg:main Feb 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants