Altmeta status is 'Active' while running by markhannum · Pull Request #5724 · bloomberg/comdb2

markhannum · 2026-02-11T15:21:58Z

Intermediary physrep sources should mark themselves as 'Active' in the altmeta database when starting.

roborivers

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
yast_stat4scan_generated
sp_twofiles_generated
sp_snapshot_generated
sp_queueodh_generated
sp
ixmap
analyze_recover_deadlock
autoanalyze
analyze_partial_index_off_generated
analyze

roborivers

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
updater_latency
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel
consumer_non_atomic_default_consumer_generated
pmux_sqlite_file_generated
truncatesc_offline_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart [core dumped]
silogdel [core dumped]
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
phys_rep_tiered_firstfile_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
osql_cleanup [core dumped]
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
unifiedcancel
sc_transactional_rowlocks_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
leakcheck [core dumped]
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
sc_truncate_lockorder_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
queuedb_rollover_noroll1_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
sc_downgrade
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart
sc_swapfields
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
sc_resume
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart [core dumped]
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
remsql_locks_rte_connect_generated
remsql_locks

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks

Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks

SChakravorti21 · 2026-03-03T18:53:05Z

+    // Sources are 'Active' or 'InActive'
+    if (gbl_physrep_source_dbname == NULL) {
+        send_reset_nodes("Active", 0);
+        // Physreps are 'InActive' until they begin replicating
+    } else {
+        send_reset_nodes("InActive", 0);
+    }
+
+    // Treat altmeta like a source: physreps which list it as primary meta
+    // should only see 'Active' or 'InActive'
+    send_reset_nodes_altmeta("Active");


For posterity: physrep's status changes to "Active" when it calls the update_registry procedure on the metadb, so that case need not be handled here.

roborivers approved these changes Feb 11, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from 3044182 to 111a772 Compare February 11, 2026 18:28

roborivers approved these changes Feb 11, 2026

View reviewed changes

roborivers approved these changes Feb 12, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch 4 times, most recently from 5e7906f to ce2c139 Compare February 14, 2026 20:50

roborivers approved these changes Feb 15, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch 5 times, most recently from 0e41573 to 640b7c6 Compare February 18, 2026 14:10

roborivers approved these changes Feb 18, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch 2 times, most recently from a8f00bd to c66b17c Compare February 18, 2026 20:51

roborivers approved these changes Feb 18, 2026

View reviewed changes

roborivers approved these changes Feb 19, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from c66b17c to 90d13e1 Compare February 19, 2026 19:16

roborivers suggested changes Feb 19, 2026

View reviewed changes

roborivers suggested changes Feb 20, 2026

View reviewed changes

roborivers approved these changes Feb 20, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch 2 times, most recently from 2ae65bb to 63ab794 Compare February 20, 2026 14:36

roborivers approved these changes Feb 20, 2026

View reviewed changes

roborivers approved these changes Feb 21, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from 63ab794 to 786c4a9 Compare February 23, 2026 15:38

roborivers approved these changes Feb 23, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from 786c4a9 to d71ac31 Compare February 23, 2026 18:37

roborivers approved these changes Feb 24, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from d71ac31 to 94f852f Compare February 24, 2026 16:14

roborivers approved these changes Feb 25, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch 2 times, most recently from eb8769c to 3cffe3d Compare February 25, 2026 19:06

roborivers approved these changes Feb 25, 2026

View reviewed changes

markhannum force-pushed the altmeta_status branch from 3cffe3d to 6fa9cca Compare February 27, 2026 14:36

roborivers approved these changes Feb 27, 2026

View reviewed changes

markhannum and others added 3 commits March 2, 2026 10:18

Altmeta status is 'Active' while running

23739fc

Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

Refactor phys-rep-tiered test

bbb40c1

Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

Changes from review (Tx Shoumyo)

5c68f05

Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

markhannum force-pushed the altmeta_status branch from 6fa9cca to 5c68f05 Compare March 2, 2026 15:19

roborivers approved these changes Mar 3, 2026

View reviewed changes

SChakravorti21 approved these changes Mar 3, 2026

View reviewed changes

SChakravorti21 reviewed Mar 3, 2026

View reviewed changes

markhannum merged commit 644f2f4 into bloomberg:main Mar 3, 2026
4 checks passed

markhannum deleted the altmeta_status branch March 3, 2026 18:55

Conversation

markhannum commented Feb 11, 2026

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

SChakravorti21 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants