{182689785} fix: normalized sql for sp#5735
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sp_snapshot_generated
recover_deadlock
fingerprints
consumer_non_atomic_default_consumer_generated
unifiedcancel
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
rishitha957
left a comment
rishitha957
left a comment
There was a problem hiding this comment.
changes look good to me, tested on my local, I'd just wait for rr tests to run.,
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
nogensc [setup failure]
silogdel [core dumped]
sc_timepart
reco-ddlk-sql
fingerprints
consumer_non_atomic_default_consumer_generated
akshatsikarwar
left a comment
akshatsikarwar
left a comment
There was a problem hiding this comment.
Please check why fingerprints test is failing.
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
feat/normalize_sql
branch
from
bb080c5 to
4de686d
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
fingerprints
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn [setup failure]
init_sc_race [core dumped]
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
4 participants
Change SQL normalization to always produce the same
normalized_sqland fingerprint regardless of argument values, types, or count. All argument tokens are stripped so that e.g. bothEXEC PROCEDURE foo(1)andEXEC PROCEDURE foo(1, 'hello', x'DEADBEEF')normalize toEXEC PROCEDURE foo();.