Open
Conversation
roborivers
suggested changes
Feb 20, 2026
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
unifiedcancel
sc_transactional_rowlocks_generated
writes_remsql_names_rte_connect_generated
writes_remsql_names_partial_index_off_generated
writes_remsql_names_fdbpushredirect_generated
writes_remsql_names_negativerowid_generated
writes_remsql_names_fdbpush_generated
02bc26a to
8818ce4
Compare
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
8818ce4 to
6321c6c
Compare
roborivers
approved these changes
Feb 21, 2026
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally the "no_coordinator_writes" test verifies that the coordinator master correctly acts as the coordinator even though there are no writes to the coordinator master itself. The "verify_no_distcommit" test verifies that we do not execute a distributed transaction if there are no foreign writes.