Skip to content

Comments

Hide more things in cdb2api#5753

Merged
chands10 merged 1 commit intobloomberg:mainfrom
chands10:moar_hide
Feb 23, 2026
Merged

Hide more things in cdb2api#5753
chands10 merged 1 commit intobloomberg:mainfrom
chands10:moar_hide

Conversation

@chands10
Copy link
Contributor

@chands10 chands10 commented Feb 20, 2026

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

@chands10
Hide more things in cdb2api
c609e0a 
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
roborivers
roborivers suggested changes Feb 21, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
sc_downgrade
reco-ddlk-sql

roborivers
roborivers suggested changes Feb 21, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: 0/ tests failed ⚠.

roborivers
roborivers suggested changes Feb 21, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

roborivers
roborivers approved these changes Feb 22, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
reco-ddlk-sql

roborivers
roborivers approved these changes Feb 22, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
scupdates [core dumped]
sp_snapshot_generated
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated

roborivers
roborivers approved these changes Feb 22, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
consumer_non_atomic_default_consumer_generated
sc_downgrade
reco-ddlk-sql

roborivers
roborivers suggested changes Feb 22, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

roborivers
roborivers approved these changes Feb 23, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers
roborivers approved these changes Feb 23, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

roborivers
roborivers approved these changes Feb 23, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

@chands10
Copy link
Contributor Author

chands10 commented Feb 23, 2026

cdb2test Feb 21 08:55:54 2026 success moar_hide.R20260221.2

@chands10 chands10 merged commit 3f7d564 into bloomberg:main Feb 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mponomar mponomar mponomar approved these changes

+1 more reviewer

@roborivers roborivers roborivers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chands10 @mponomar @roborivers