Skip to content

Version Chooser: display response text contents on tag fetching error#3805

Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:show_tag_error
Feb 23, 2026
Merged

Version Chooser: display response text contents on tag fetching error#3805
patrickelectric merged 1 commit intobluerobotics:masterfrom
Williangalvani:show_tag_error

Conversation

@Williangalvani
Copy link
Copy Markdown
Member

@Williangalvani Williangalvani commented Feb 23, 2026

Summary by Sourcery

Bug Fixes:

  • Expose the HTTP status and response body in the error thrown when DockerHub tag fetching fails to aid debugging and diagnosis.

@cursor
Copy link
Copy Markdown

cursor Bot commented Feb 23, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 15.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhances DockerHub tag fetching error reporting by including HTTP status and response body text in the raised exception when the response is non-200.

Sequence diagram for enhanced DockerHub tag fetching error reporting

sequenceDiagram
    participant VersionChooserDockerHubClient as VersionChooserDockerHubClient
    participant DockerHubAPI as DockerHubAPI

    VersionChooserDockerHubClient->>DockerHubAPI: GET /v2/repositories/{repository}/tags
    DockerHubAPI-->>VersionChooserDockerHubClient: HTTP response (status != 200)
    VersionChooserDockerHubClient->>VersionChooserDockerHubClient: warn Error status resp.status
    VersionChooserDockerHubClient->>DockerHubAPI: await resp.text()
    DockerHubAPI-->>VersionChooserDockerHubClient: response_text
    VersionChooserDockerHubClient->>VersionChooserDockerHubClient: raise RuntimeError("Failed getting tags from DockerHub! {status} {response_text}")
Loading

File-Level Changes

Change Details Files
Improve DockerHub tag fetch error message with HTTP status and response body text.
  • Update the RuntimeError message thrown on non-200 responses to include the HTTP status code and response text from the DockerHub API response.
  • Keep the existing behavior of logging a warning and raising an exception on non-200 responses before attempting to parse JSON.
core/services/versionchooser/utils/dockerhub.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Including the full resp.text() in the exception message can generate extremely large or sensitive error strings; consider truncating the body to a reasonable length and/or sanitizing it before raising to avoid log bloat and potential leakage.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Including the full `resp.text()` in the exception message can generate extremely large or sensitive error strings; consider truncating the body to a reasonable length and/or sanitizing it before raising to avoid log bloat and potential leakage.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit a7cc995 into bluerobotics:master Feb 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants