frontend: views: ExtensionManagerView: center extension manager tabs#3869
frontend: views: ExtensionManagerView: center extension manager tabs#3869nicoschmdt wants to merge 1 commit intobluerobotics:masterfrom
Conversation
Reviewer's GuideCenters the Extension Manager tabs within the toolbar and keeps the Settings button aligned to the right via flexbox and responsive CSS adjustments. Flow diagram for ExtensionManagerView toolbar layout changesflowchart LR
ExtensionToolbar[ExtensionToolbar v_toolbar extension_toolbar] --> ExtensionTabs[ExtensionTabs v_tabs extension_tabs]
ExtensionToolbar --> SettingsButton[SettingsButton v_btn extension_toolbar_settings]
subgraph FlexLayout
ExtensionTabsFlex[extension_tabs flex 1_1_0 min_width 0]
SettingsButtonFlex[extension_toolbar_settings flex_shrink 0]
end
ExtensionTabs --> ExtensionTabsFlex
SettingsButton --> SettingsButtonFlex
subgraph DesktopMediaQuery min_width_900px
SettingsButtonPosition[extension_toolbar_settings position absolute right 16px top 50_percent translateY_minus_50_percent]
end
SettingsButtonFlex --> DesktopMediaQuery
DesktopMediaQuery --> SettingsButtonPosition
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The custom centering and right-align behavior for the toolbar could likely be expressed using Vuetify’s layout utilities (e.g.,
justify-center,v-spacer,class="ml-auto") instead of absolute positioning, which would simplify the CSS and reduce layout edge cases. - Consider replacing the hardcoded
@media (min-width: 900px)andright: 16pxbreakpoint/spacing values with existing design system or Vuetify breakpoint/spacing tokens so the layout stays consistent with the rest of the app’s responsive behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The custom centering and right-align behavior for the toolbar could likely be expressed using Vuetify’s layout utilities (e.g., `justify-center`, `v-spacer`, `class="ml-auto"`) instead of absolute positioning, which would simplify the CSS and reduce layout edge cases.
- Consider replacing the hardcoded `@media (min-width: 900px)` and `right: 16px` breakpoint/spacing values with existing design system or Vuetify breakpoint/spacing tokens so the layout stays consistent with the rest of the app’s responsive behavior.
## Individual Comments
### Comment 1
<location path="core/frontend/src/views/ExtensionManagerView.vue" line_range="218-226" />
<code_context>
/>
- <v-toolbar>
- <v-spacer />
+ <v-toolbar class="extension-toolbar">
<v-tabs
v-model="tab"
</code_context>
<issue_to_address>
**issue (bug_risk):** Absolute positioning of the settings button may overlap the tabs without reserving horizontal space.
With `.extension-toolbar-settings` absolutely positioned, the tabs can extend underneath it because the toolbar no longer reserves horizontal space for the button. Around the breakpoint this can cause the settings icon to overlap tab labels or arrows.
Consider adding right padding or a max-width on `.extension-toolbar` (or similar layout change) so the tabs never render under the settings icon.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <v-toolbar class="extension-toolbar"> | ||
| <v-tabs | ||
| v-model="tab" | ||
| fixed-tabs | ||
| show-arrows | ||
| class="extension-tabs" | ||
| > | ||
| <v-tab key="0" href="#0" class="tab-text"> | ||
| <v-icon class="mr-3"> |
There was a problem hiding this comment.
issue (bug_risk): Absolute positioning of the settings button may overlap the tabs without reserving horizontal space.
With .extension-toolbar-settings absolutely positioned, the tabs can extend underneath it because the toolbar no longer reserves horizontal space for the button. Around the breakpoint this can cause the settings icon to overlap tab labels or arrows.
Consider adding right padding or a max-width on .extension-toolbar (or similar layout change) so the tabs never render under the settings icon.
fix #2942
before:

zoomed-in:

after:

zoomed-in:

Summary by Sourcery
Center the extension manager tab bar while keeping the settings button consistently positioned.
Enhancements: