[WIP] Add CSV parser#234
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
Needs @brianhBR approval. |
| //Check for valid checksum and id | ||
| ping_msg_ping1D_empty ping_message{(uint8_t*)(packages[i].data()), (uint16_t)packages[i].length()}; | ||
| if(!ping_message.verifyChecksum()) { | ||
| continue; |
jaxxzer
left a comment
jaxxzer
left a comment
There was a problem hiding this comment.
We need timestamps in the csv.
|
I'm wondering what's the most useful thing here. For example, if we receive distance info from two different messages, the data lands in two different files. Perhaps we should stick to only pertinent information (confidence, range, profile) and interleave this data from all messages into one output file. Meanwhile, we can forgo exporting things like firmware version, voltage, scan range etc. This consideration should not hold up this PR, however. |
jaxxzer
left a comment
jaxxzer
left a comment
There was a problem hiding this comment.
Why are all the function mappings returning floats?
Is it because the functions in the map must all have the same type?
I would like to add each variable in a different tab in excel, and in the end only one file with a bunch of tabs. But this will need second party libraries or new classes to handle everything. This is a simple and good first version.
Exactly: |
|
Add timestamps or open an issue for it after merge. |
|
Closing due to inactivity. |
2 participants
Fix #131
Needs #61