bugfix exported bundle version in upload to maven repo#7102
Merged
Conversation
chrisrueger
reviewed
Feb 17, 2026
peterkir
force-pushed
the
bugfix-exported-bundle-versions
branch
5 times, most recently
from
6ffeac8 to
ef312ed
Compare
Signed-off-by: Peter Kirschner <peter@klib.io>
peterkir
force-pushed
the
bugfix-exported-bundle-versions
branch
from
ef312ed to
d4e9f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive test coverage for the
-snapshotinstruction's effect on Maven POM version generation and implements the logic to apply the-snapshottransformation to the version inPomResource. The changes ensure that when building POM files, anySNAPSHOTqualifier in the version is replaced or removed according to the-snapshotproperty, and this is now thoroughly tested for various scenarios.Test coverage improvements
MavenTest.javato verify that the-snapshotinstruction correctly transformsSNAPSHOTversions in generated POM files, including cases with custom snapshot values, empty snapshots (removal), and qualifiers ending in-SNAPSHOT. These tests also cover integration with Maven repository layouts.Core logic enhancement
PomResourceto apply the-snapshotproperty transformation to the version string when generating the POM, using theBuilder.doSnapshotmethod. This ensures the generated POM version matches the intended release or snapshot semantics. [1] [2]