Enable oscars behind feature flags in boa_gc#5115
Open
nekevss wants to merge 3 commits intoboa-dev:mainfrom
Open
Enable oscars behind feature flags in boa_gc#5115nekevss wants to merge 3 commits intoboa-dev:mainfrom
nekevss wants to merge 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Broken tests (22):Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5115 +/- ##
===========================================
+ Coverage 47.24% 59.20% +11.96%
===========================================
Files 476 563 +87
Lines 46892 62793 +15901
===========================================
+ Hits 22154 37178 +15024
- Misses 24738 25615 +877 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
reviewed
Mar 18, 2026
Comment on lines
+27
to
+28
| # Unstable feature | ||
| unstable = [] |
Member
There was a problem hiding this comment.
Why the unstable feature? Is it not enough to have the oscars feature to gate the new GC?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
unstableandoscarsfeature flag and re-exports the oscars repo fromboa_gc.