fix: parse comma-separated field declarations#108
Open
abanchev wants to merge 3 commits intobobbylight:masterfrom
Open
fix: parse comma-separated field declarations#108abanchev wants to merge 3 commits intobobbylight:masterfrom
abanchev wants to merge 3 commits intobobbylight:masterfrom
Conversation
The parser only recognized the first variable in multi-variable field declarations. Subsequent variables (after commas) were silently ignored, causing autocomplete to fail for those identifiers. After parsing the first field, loop on SEPARATOR_COMMA to create additional Field objects for each subsequent identifier. Applied to both class body and interface body parsing paths. Includes test coverage with a multi-variable declaration in SimpleClass.java and assertions in ClassAndLocalVariablesTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type a, b, c;SEPARATOR_COMMAto create additionalFieldobjects for each subsequent identifierTest plan
public String multiA, multiB, multiC;) toSimpleClass.javatest fixtureClassAndLocalVariablesTestverifying all three fields are parsed with correct name, type, and modifiers