Conversation
| } | ||
| } | ||
|
|
||
| if ($isData) { |
There was a problem hiding this comment.
Moved this logic to Utils.php as requested here https://gitlab.com/pegadigital/bolt/design-system/-/merge_requests/172/diffs#abc6908e4ce44dffaf341cb178f23e9d085294ce_236_247
danielamorse
left a comment
danielamorse
left a comment
There was a problem hiding this comment.
I'm not sure I understand which Utils.php file is the real Utils.php file anymore 😅
If this logic was moved to Gitlab, shouldn't it be removed here?
Also, should we be targeting the release/8.x branch?
|
I think we are saying this Github version is the new source of truth @danielamorse, because it can be pulled into Drupal (unlike the Bolt version, which would require a release). I think by "moved this logic", Andrew is talking about it going from one file (twigFunctions.php) to another (Utils.php), which was my suggestion when I first reviewed this in the other (Gitlab designsystem) PR. @andrewmriv, please correct me if I'm off here. |
3 participants
No description provided.