credentials: Use remote-fs.target for virtiofs mount ordering#204
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Feb 5, 2026
Merged
Conversation
The original mount unit configuration used Before=local-fs.target, which could cause issues with virtiofs mounts that depend on virtio transport infrastructure being available. Change the mount units to use Before=remote-fs.target instead. This is more appropriate because virtiofs is conceptually similar to a remote filesystem - it requires external infrastructure (virtio transport) to be available, similar to how NFS requires network connectivity. This follows systemd conventions where remote-fs.target is used for filesystems that depend on infrastructure beyond the local disk. Assisted-by: OpenCode (Claude claude-opus-4-5-20250114) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
fix-virtiofs-mount-ordering
branch
from
705845a to
9e05e3e
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly changes the systemd mount unit ordering for virtiofs mounts from local-fs.target to remote-fs.target. This is a logical improvement, as virtiofs filesystems depend on the virtio transport infrastructure, making them conceptually similar to remote filesystems. The changes are applied consistently, and the reasoning is well-documented in comments and the PR description. I have one minor suggestion to improve the documentation's accuracy.
gursewak1997
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original mount unit configuration used Before=local-fs.target, which could cause issues with virtiofs mounts that depend on virtio transport infrastructure being available.
Change the mount units to use Before=remote-fs.target instead. This is more appropriate because virtiofs is conceptually similar to a remote filesystem - it requires external infrastructure (virtio transport) to be available, similar to how NFS requires network connectivity.
This follows systemd conventions where remote-fs.target is used for filesystems that depend on infrastructure beyond the local disk.
Assisted-by: OpenCode (Claude claude-opus-4-5-20250114)