install: add progress-fd for install#1431
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces progress reporting for install commands via the --progress-fd option. The implementation correctly passes the ProgressWriter through the necessary functions to provide progress during image pulls. The new functionality is also covered by tests. I've identified one area for improvement concerning an unused function parameter that should be addressed to enhance code clarity.
f282db3 to
c77a63c
Compare
Co-authored-by: Colin Walters <walters@verbum.org> Assisted by: Claude Code Signed-off-by: Joseph Marrero Corchado <jmarrero@redhat.com>
c77a63c to
3941437
Compare
|
For tests I'd add to (tangent but I'm not totally happy with the nushell stuff in the end, it's not bad but it's obscure enough that AI tools IME confabulate a lot. The Rust tests are OK but one general issue there is frameworks like TMT don't make it easy (afaik) to use tests that are compiled, the framework wants to just copy arch-independent scripts/yaml from a git repo) |
Assisted by: Claude Code
This supersedes #982 and is part of #1016
Draft because I have not tested this actually does what we want other than making the tests pass.