chore(deps): update cargo dependencies#1499
chore(deps): update cargo dependencies#1499cgwalters merged 2 commits intobootc-dev:mainfrom rsturla:update-major-minor-patch
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a large number of dependencies across the workspace. The changes primarily consist of version bumps in Cargo.toml files and the necessary code modifications to address breaking changes from these updates. The fixes correctly handle API changes in crates like rustix, toml, and tempfile, and also resolve new lifetime requirements in various function signatures. The code adaptations are well-executed and essential for the dependency upgrades. Overall, the changes are solid and contribute to the project's maintainability by keeping its dependencies current.
|
Remaining changes (to be pushed):
GitHub Copilot gave up on this too, and ended up removing the ocidir crate in frustration 😆 |
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| serde = { workspace = true, features = ["derive"] } | ||
| serde_json = { workspace = true } | ||
| serde_yaml = "0.9.22" | ||
| serde_yaml = "0.9.34" |
There was a problem hiding this comment.
I think we should actually be moving more of these common dependencies into the workspace - that's a different PR
Yeah we need to fix that for sure soon... |
Signed-off-by: Robert Sturla <robertsturla@outlook.com>
Signed-off-by: Robert Sturla <robertsturla@outlook.com>
2 participants
1.6.0 just dropped, so I think it would be good to try and tackle this now while we have 3 weeks of testing.
An attempt to get Renovate back up and running on this repo. Updates all Cargo dependencies bar ocidir.
Looking through the changes, all make sense. There were some breakages which I have resolved, though I am counting on CI to confirm I haven't broken anything myself. The vast majority of the breaking changes were straight forward function swaps that don't appear to change functionality in a visible way to us.
Split minor/patch and major bumps into separate commits.
Changes (such as the lifetime ones) were ran through ChatGPT for a sanity check, to figure out why these were showing a warning and that the recommended fix is almost certainly correct.
Once merged, please close and delete the existing dependency update branch, and Renovate should take over next week.