Bump composefs-rs and containers-image-proxy#1973
Bump composefs-rs and containers-image-proxy#1973Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Conversation
Mainly includes containers/composefs-rs@deda942 which fixes an error encountered when pulling from containers-storage Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates two dependencies: composefs-rs is updated to a newer revision to incorporate an upstream bug fix, and containers-image-proxy is bumped to version 0.9.2. The changes are straightforward and correct.
I have one suggestion to improve maintainability by moving the containers-image-proxy dependency to be managed by the workspace, as it's used by multiple crates.
Additionally, I noticed that many of the crate-specific dependencies in crates/ostree-ext/Cargo.toml are pinned to older versions than what is resolved in Cargo.lock. While Cargo's dependency resolution handles this correctly for now, it would be beneficial to update these versions in a follow-up PR to improve clarity and prevent potential future dependency conflicts.
| # Crate-specific dependencies | ||
| comfy-table = "7.1.1" | ||
| containers-image-proxy = "0.9.1" | ||
| containers-image-proxy = "0.9.2" |
There was a problem hiding this comment.
For better maintainability and to ensure version consistency across the workspace, it's a good practice to manage shared dependencies in the root Cargo.toml. Since containers-image-proxy is also a dependency of another crate in your dependency tree (composefs-oci), consider moving its definition to the [workspace.dependencies] table and inheriting it here.
This would involve adding the following to the [workspace.dependencies] section of the root Cargo.toml:
containers-image-proxy = "0.9.2"And then changing this line to use the workspace definition.
| containers-image-proxy = "0.9.2" | |
| containers-image-proxy = { workspace = true } |
Mainly includes
containers/composefs-rs@deda942
which fixes an error encountered when pulling from containers-storage