Skip to content

Bump composefs-rs and containers-image-proxy#1973

Open
Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Johan-Liebert1:bump-cfs
Open

Bump composefs-rs and containers-image-proxy#1973
Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Johan-Liebert1:bump-cfs

Conversation

@Johan-Liebert1
Copy link
Collaborator

Mainly includes
containers/composefs-rs@deda942
which fixes an error encountered when pulling from containers-storage

Mainly includes
containers/composefs-rs@deda942
which fixes an error encountered when pulling from containers-storage

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
@github-actions github-actions bot added the area/ostree Issues related to ostree label Feb 4, 2026
@bootc-bot bootc-bot bot requested a review from jeckersb February 4, 2026 07:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates two dependencies: composefs-rs is updated to a newer revision to incorporate an upstream bug fix, and containers-image-proxy is bumped to version 0.9.2. The changes are straightforward and correct.

I have one suggestion to improve maintainability by moving the containers-image-proxy dependency to be managed by the workspace, as it's used by multiple crates.

Additionally, I noticed that many of the crate-specific dependencies in crates/ostree-ext/Cargo.toml are pinned to older versions than what is resolved in Cargo.lock. While Cargo's dependency resolution handles this correctly for now, it would be beneficial to update these versions in a follow-up PR to improve clarity and prevent potential future dependency conflicts.

# Crate-specific dependencies
comfy-table = "7.1.1"
containers-image-proxy = "0.9.1"
containers-image-proxy = "0.9.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to ensure version consistency across the workspace, it's a good practice to manage shared dependencies in the root Cargo.toml. Since containers-image-proxy is also a dependency of another crate in your dependency tree (composefs-oci), consider moving its definition to the [workspace.dependencies] table and inheriting it here.

This would involve adding the following to the [workspace.dependencies] section of the root Cargo.toml:

containers-image-proxy = "0.9.2"

And then changing this line to use the workspace definition.

Suggested change
containers-image-proxy = "0.9.2"
containers-image-proxy = { workspace = true }

@Johan-Liebert1 Johan-Liebert1 added area/composefs Issues related to composefs and removed area/ostree Issues related to ostree labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/composefs Issues related to composefs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants