fix: restrict folder dialog to file:// URLs (#1631)#2476
Open
OsamaGharibElwaly wants to merge 1 commit intoborgbase:masterfrom
Open
fix: restrict folder dialog to file:// URLs (#1631)#2476OsamaGharibElwaly wants to merge 1 commit intoborgbase:masterfrom
OsamaGharibElwaly wants to merge 1 commit intoborgbase:masterfrom
Conversation
Sets QFileDialog supportedSchemes to file only for choose_file_dialog (add repo, mount, extract). Adds unit test. Made-with: Cursor
m3nu
approved these changes
Mar 28, 2026
Contributor
m3nu
left a comment
m3nu
left a comment
There was a problem hiding this comment.
Minimal, correct fix for #1631. QFileDialog.setSupportedSchemes(['file']) is the documented Qt mechanism and all Vorta file dialogs only need local filesystem access.
- Placement after
setOption(ShowDirsOnly)is fine -- order doesn't matter for these independent properties - Applied unconditionally to both folder and file pickers, which is correct
- Test verifies
setSupportedSchemesis called with the right argument
No issues found. Ready to merge once CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets \QFileDialog.setSupportedSchemes(['file'])\ in \choose_file_dialog()\ so the add-repo, mount, and extract folder pickers do not offer unsupported schemes (e.g. \smb://, \sftp://) that can freeze or misbehave on some platforms.
Testing
Related to #1631