feat: show user-friendly dialog when repository is not found (#1815)#2487
Open
tusharynayaka wants to merge 3 commits intoborgbase:masterfrom
Open
feat: show user-friendly dialog when repository is not found (#1815)#2487tusharynayaka wants to merge 3 commits intoborgbase:masterfrom
tusharynayaka wants to merge 3 commits intoborgbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a specific error handling check for Borg's "repository does not exist" exit code (Borg return code 2) in the repository addition workflow. Instead of failing silently or providing a generic error, Vorta now displays a clear QMessageBox informing the user that the path was not found and suggests checking the URL.
Related Issue
Fixes #1815
Motivation and Context
Currently, when a user enters an incorrect or non-existent repository path in the "Add Existing Repository" dialog, the feedback is either non-existent or confusing (often falling back to a "Borg binary not found" state if the process fails). This change improves the onboarding UX by giving immediate, actionable feedback when a path is mistyped.
How Has This Been Tested?
Environment:
OS: Windows 11
Backend: Borg 1.2.8 running via WSL2
Bridge: Custom batch script to route Windows Vorta calls to WSL Borg.
Types of changes
[x] New feature (non-breaking change which adds functionality)
Checklist:
[x] I have read the CONTRIBUTING guide.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.