Skip to content

chore: bump i18next peer dependency #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thgh wants to merge 1 commit into from
Closed

chore: bump i18next peer dependency #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/translations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@
"i18next-multiload-backend-adapter": "^1.0.0"
},
"peerDependencies": {
"i18next": "^20.0.0",
"i18next": "^21.0.0",
Copy link
Copy Markdown
Contributor

@JaccoGoris JaccoGoris May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also requires giving the translations package a major bump, so we don't slip in a breaking change for users down stream

Copy link
Copy Markdown
Member Author

@thgh thgh May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good reflex! But as mentioned in the commit and PR:

This does not have any impact for dependents except for a warning on install.

Peer dependencies have 0 impact on the outcome (filewise) of npm/yarn. Only the output will show a yellow warning. Looking at existing projects, most are already using 21 so this would actually resolve this.

Copy link
Copy Markdown
Contributor

@JaccoGoris JaccoGoris Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"i18next": "^21.0.0",
"i18next": "20 - 21",

is the best solution here I think. we've also used this in the eslint config: https://github.com/bothrs/eslint-config/blob/main/package.json#L83
notice also that peer dependencies never have a ^ or full version number like 21.0.0

"react": ">=16.x"
},
"devDependencies": {
"@types/node": "^16.11.6",
"@types/react": "^17.0.24",
"i18next": "^20.0.0",
"i18next": "^21.0.0",
"parcel": "^2.0.0",
"tslib": "^2.3.1",
"typescript": "^4.4.2"
Expand Down