refactor: Fix typos and suppress unhandled VOICE_CHANNEL_START_TIME_UPDATE event#1561
Merged
Jaskowicz1 merged 1 commit intobrainboxdotcc:devfrom Mar 22, 2026
Merged
Conversation
…DATE event - Fix doxygen comment for get_bytes_out() in sslconnection.h - Fix "New of clients" -> "New number of clients" in DAVE voice log message - Add VOICE_CHANNEL_START_TIME_UPDATE to event map to suppress debug noise
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
github-actions
bot
added
documentation
Jaskowicz1
approved these changes
Mar 21, 2026
Jaskowicz1
changed the title
Contributor
|
Thanks for you first contribution! I've approved the PR and workflows, will merge when everything passes 😄 |
braindigitalis
approved these changes
Mar 21, 2026
Contributor
|
lgtm, thanks for the pr! |
Author
|
Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes I noticed while looking through the codebase:
get_bytes_out()had a garbled string (Get the bytes out objectGet total bytes sent). Cleaned it up to match the style ofget_bytes_in()right below it."New of clients in voice channel"which is missing a word — changed to"New number of clients in voice channel".VOICE_CHANNEL_START_TIME_UPDATEis a gateway event that Discord sends (e.g. when bots are moved between voice channels), but it wasn't in the event map. This caused noisyUnhandled eventdebug log lines. Added it as a silently-ignored entry, same as the other events we don't need to handle likeVOICE_CHANNEL_STATUS_UPDATE.Code change checklist