BAF-1256 # Module Gateway - QUIC Integration by danprudky · Pull Request #49 · bringauto/module-gateway

danprudky · 2026-01-07T09:00:03Z

Implementation of Quic external client connection

Add user and change workingdirectory, so it does work by default with Package to Image Placer. Ensure that config path is absolute.

…-file Change systemd file

coderabbitai · 2026-01-07T09:00:34Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 58db35c4-5eb1-4e6d-8445-6ab37a60c54a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch BAF-1256/use_quic_external_client

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

koudis · 2026-01-13T14:24:21Z

CMakeLists.txt

                        ZLIB::ZLIB
                        fleet-protocol-cxx-helpers-static::fleet-protocol-cxx-helpers-static
                        async-function-execution-shared::async-function-execution-shared
+                        msquic


The msquic shall be added as a dependency to the Fleet Protocol Context
https://github.com/bringauto/packager-fleet-protocol-context

@koudis will add it in week 19. 1. 2026

dominikmelicher · 2026-01-14T07:16:00Z

include/bringauto/common_utils/EnumUtils.hpp

+			case CONNECTING: return "Connecting";
+			case CONNECTED: return "Connected";
+			case CLOSING: return "Closing";
+			default: return "Unknown";


Use string constants like loggerVerbosityToString.
Put each return statements on a new line, like in loggerVerbosityToString.

Resolved in 3e5df14

dominikmelicher · 2026-01-14T07:25:52Z

include/bringauto/external_client/connection/communication/QuicCommunication.hpp

+			QUIC_BUFFER buffer{};
+			std::string storage;
+
+			explicit SendBuffer(size_t size)


Maybe add a small docstring for struct SendBuffer, but definitely add a docstring for the constructor saying, that it initializes the buffer to size and fills it with zeroes

Resolved in e74bc2a

dominikmelicher · 2026-01-14T07:28:10Z

resources/config/quic_example.json

update the README in resources/config with descriptions of the new options you added

Resolved in c1b3a8c

dominikmelicher · 2026-01-14T08:14:10Z

source/bringauto/external_client/connection/communication/QuicCommunication.cpp

+		{
+			auto copy = std::make_shared<ExternalProtocol::ExternalClient>(*message);
+			std::scoped_lock lock(outboundMutex_);
+			outboundQueue_.push(std::move(copy));


use unique_ptr - std::move(outboundQueue_.front()) and then outboundQueue_.pop() should work fine

also just a nitpick, but if you're only locking a single mutex, use lock_guard instead of scoped_lock

Resolved in 30123d9

dominikmelicher · 2026-01-14T08:22:36Z

source/bringauto/external_client/connection/communication/QuicCommunication.cpp

+		alpnBuffer_.Length = static_cast<uint32_t>(alpn_.size());
+
+		loadMsQuic();
+		initRegistration("module-gateway-quic-client");


"module-gateway-quic-client" should be defined as a constexpr string_view, also if initRegistration is only going to be used like this, and the appName will not be configurable, then initRegistration should just have no arguments and use this constant directly

Resolved in 5853c70

dominikmelicher · 2026-01-14T09:05:11Z

source/bringauto/external_client/connection/communication/QuicCommunication.cpp

+	}
+
+	void QuicCommunication::initConfiguration() {
+		configurationOpen(nullptr);


I think you should parse the config for QUIC_SETTINGS as well, the JSON keys could just be the same as the member names in https://github.com/microsoft/msquic/blob/main/docs/api/QUIC_SETTINGS.md, should probably be done in a new static class, responsible for QUIC config parsing, since there's a lot of options - you will need something slightly different from getProtocolSettingsString, each of the QUIC_SETTINGS should be optional, so it can't throw when it doesn't find the key, also you will need to parse the value as an unsigned integer, not just a string

we probably don't need all the settings, probably just allow parsing of timeout settings for now
just make it simple to add any additional options we might need in the future

Resolved in be11942

dominikmelicher · 2026-01-14T12:14:08Z

source/bringauto/external_client/connection/communication/QuicCommunication.cpp

+					event->RECEIVE.BufferCount
+				);
+
+				std::vector<uint8_t> data;


according to https://github.com/microsoft/msquic/blob/main/docs/Streams.md#Receiving, BufferCount == 0 is valid and means end of stream data, maybe handle it as well?

Resolved in d2303a7

This is not treated as stream termination; data processing is skipped only.

sonarqubecloud · 2026-01-19T08:27:05Z

Quality Gate failed

Failed conditions
3 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

…nction

- Fixed StatusAggregator::aggregateStatus returning empty buffer on error - Removed unreachable contains() check in clear_device - Fixed getDeviceTimeoutCount using operator[] (silent insert); marked const - Fixed Connection::remoteEndpointAddress using throwing remote_endpoint - Fixed InternalServer set_option using throwing overload in async handler - Removed dead code (unused deviceId) in ModuleHandler::destroy - Fixed LoggerWrapper::init to take only logger name; verbosity is always the compile-time template parameter - Renamed MODULE_GATEWAY_MINIMUM_LOGGER_VERBOSITY to BRINGAUTO_MODULE_GATEWAY_MINIMUM_LOGGER_VERBOSITY; added STRINGS validation - Fixed misleading comments in LoggerWrapper - Fixed mixed indentation in EnumUtils.cpp DUMMY branch - Added per-value docs to ProtocolType enum with DUMMY reconnect-loop warning - Removed dead settingsName assignment for DUMMY in serializeToJson - Removed pointless sync_with_stdio/cin.tie and unused include from main.cpp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Increased version of cxxopts from v3.0.5 to v3.1.1 Increased version of nlohmann_json from v3.2.0 to v3.10.5

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add Aeron/Async and Module Binary

…improved state debugging

…rectional communication

…ove outdated code sections, and organize code structure for clarity.

…ogging for stream events, and clean up debug code.

…ror handling with `StreamShutdown`, and clean up unused callbacks and logging.

…mprove stream and connection logging, and clean up unnecessary debug code.

…hod, improve handling of JSON-encoded protocol settings, and refine `SettingsParser` logic for cleaner value parsing.

…ne logging messages for clarity, and remove unused includes.

…better error handling, improve sender loop logic, and refine logging for message and connection events.

…ng messages.

…ate with external_client::connection::ConnectionState

…ings::Constants::ALPN` for improved configurability.

…s after `receiveMessage` calls.

…sistent include order and readability.

…ed memory handling, update QUIC stream send logic, refine logging with stream IDs, and switch `initRegistration` to use `std::string`.

…er::logError` for error handling and ensure graceful returns in failure scenarios.

…::unique_ptr` with `std::string` for memory management.

…proper setup before logging.

…oped_lock` and simplify enum string conversion using `using enum`.

… event.

…initRegistration` with a constant for simplification and improved consistency.

…ique_ptr` in outbound queue, update `sendViaQuicStream` to use references for improved memory management and clarity.

…pand protocol support, and provide examples for both.

…dBuffer` to clarify purpose, usage, and construction.

… `settings::Constants` for improved maintainability.

…uicCommunication`.

sonarqubecloud · 2026-03-04T08:49:28Z

Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)
7 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

mikusaq added 2 commits August 5, 2025 09:12

Change systemd file

8e14ed2

Add user and change workingdirectory, so it does work by default with Package to Image Placer. Ensure that config path is absolute.

Merge pull request #46 from bringauto/BAF-1129/change-systemd-service…

4fb6c5a

…-file Change systemd file

danprudky requested a review from dominikmelicher January 7, 2026 12:12

koudis reviewed Jan 13, 2026

View reviewed changes

dominikmelicher requested changes Jan 14, 2026

View reviewed changes

jiriskuta force-pushed the BAF-1256/use_quic_external_client branch from be11942 to bf7ee48 Compare February 18, 2026 19:42

MarioIvancik and others added 22 commits February 24, 2026 19:47

performance/networking optimizations

675c090

static analysis fixes

c85946b

update versions

4b2d408

dont move const references; remade logger id macros to a constexpr fu…

32542c9

…nction

fix cmake; add dummy communication documentation

da2e698

fix test init

fcfca35

fix some unit tests

496649c

skip not needed unit test

7c2db49

made stringsEqual inaccessible in other files

413fb5f

Added CMCONF init

a1a9cdc

Increased version of cxxopts from v3.0.5 to v3.1.1 Increased version of nlohmann_json from v3.2.0 to v3.10.5

Fixed review issues: bugs, missing headers, dead code, const correctness

6d9b560

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Baf 1155/use async client (#47)

c01b697

Add Aeron/Async and Module Binary

added aeron classes for initial testing

fc1f45e

check returned messages from aeron client

8d73bea

functional aeron module communication

81fa98b

added docstrings for AeronClient

dd4575e

async function execution usage

68a2bd6

refactor of module library handler

08527fc

added mutexes for async client; use filesystem::path for file paths

d5c5b40

removed memory management; added module based channel offset

55dda16

added error handling to async module

c12c9c3

Daniel Prudky and others added 28 commits March 4, 2026 09:46

Add toString method for ConnectionState in QuicCommunication for …

f31b17a

…improved state debugging

Implement message queuing and threading in QuicCommunication for bidi…

721431f

…rectional communication

Refactor QuicCommunication: Improve comments and documentation, rem…

6621621

…ove outdated code sections, and organize code structure for clarity.

Refactor QuicCommunication: Extract getStreamId method, improve l…

ef8ab3d

…ogging for stream events, and clean up debug code.

Refactor QuicCommunication: Simplify StreamSend logic, improve er…

af3d68c

…ror handling with `StreamShutdown`, and clean up unused callbacks and logging.

Refactor QuicCommunication: Add detailed event handling comments, i…

d355358

…mprove stream and connection logging, and clean up unnecessary debug code.

Refactor QuicCommunication: Extract getProtocolSettingsString met…

bfeb1a4

…hod, improve handling of JSON-encoded protocol settings, and refine `SettingsParser` logic for cleaner value parsing.

Refactor QuicCommunication: Replace logInfo with logDebug, refi…

73a5a45

…ne logging messages for clarity, and remove unused includes.

Refactor QuicCommunication: Replace error logs with exceptions for …

c3791cb

…better error handling, improve sender loop logic, and refine logging for message and connection events.

Refactor QuicCommunication: Add connection state check before sendi…

c8eb175

…ng messages.

Refactor QuicCommunication: Replace QuicCommunication::ConnectionSt…

40f56ae

…ate with external_client::connection::ConnectionState

Refactor QuicCommunication: Replace hardcoded ALPN value with `sett…

f804ba6

…ings::Constants::ALPN` for improved configurability.

Add quic_example.json configuration file for QUIC module settings

1de43e0

Refactor ExternalConnection: Remove redundant return OK statement…

3000abb

…s after `receiveMessage` calls.

Clean up includes in ExternalClient and QuicCommunication for con…

102b45d

…sistent include order and readability.

Refactor QuicCommunication: Add SendBuffer abstraction for improv…

6088c0e

…ed memory handling, update QUIC stream send logic, refine logging with stream IDs, and switch `initRegistration` to use `std::string`.

Refactor QuicCommunication: Replace exceptions with `settings::Logg…

abda17a

…er::logError` for error handling and ensure graceful returns in failure scenarios.

Refactor QuicCommunication: Simplify SendBuffer by replacing `std…

e06b252

…::unique_ptr` with `std::string` for memory management.

Refactor QuicCommunication: Reorder initialization steps to ensure …

b6bec1b

…proper setup before logging.

Refactor QuicCommunication: Replace std::lock_guard with `std::sc…

bb7dda9

…oped_lock` and simplify enum string conversion using `using enum`.

Refactor QuicCommunication: Add early exit for empty stream receive…

e74e801

… event.

Refactor QuicCommunication: Replace dynamic app name parameter in `…

0255de1

…initRegistration` with a constant for simplification and improved consistency.

Refactor QuicCommunication: Replace std::shared_ptr with `std::un…

ba440af

…ique_ptr` in outbound queue, update `sendViaQuicStream` to use references for improved memory management and clarity.

Update README.md: Add QUIC configuration details alongside MQTT, ex…

250bcde

…pand protocol support, and provide examples for both.

Refactor QuicCommunication: Add comments and documentation for `Sen…

ec42fd1

…dBuffer` to clarify purpose, usage, and construction.

Refactor EnumUtils: Replace hardcoded connection state strings with…

e96c185

… `settings::Constants` for improved maintainability.

Add QuicSettingsParser to parse QUIC settings and integrate with `Q…

70aa83b

…uicCommunication`.

Reformatted long lines

1bee77f

jiriskuta force-pushed the BAF-1256/use_quic_external_client branch from bf7ee48 to 1bee77f Compare March 4, 2026 08:47

Conversation

danprudky commented Jan 7, 2026

Uh oh!

coderabbitai bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 19, 2026

Quality Gate failed

Uh oh!

sonarqubecloud bot commented Mar 4, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai bot commented Jan 7, 2026 •

edited

Loading