remove need for project id in Browserbase params if already passed to stagehand#196
Merged
miguelg719 merged 4 commits intomainfrom Sep 10, 2025
Merged
remove need for project id in Browserbase params if already passed to stagehand#196miguelg719 merged 4 commits intomainfrom
miguelg719 merged 4 commits intomainfrom
Conversation
… id to browserbase params before field validation
miguelg719
requested changes
Sep 10, 2025
miguelg719
approved these changes
Sep 10, 2025
miguelg719
approved these changes
Sep 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying from Derek's branch: #170
why
if you add custom browserbase create params, you need to include the project id even if the project id is already passed to the stagehand instance
what changed
relaxed browserbase params definition and added a field validator to add project id from the stagehand config before validating structure
test plan
ran tests with shell command