fix: convert scroll_at direction/magnitude to scroll_x/scroll_y in GoogleCUAClient#263
Open
t-anjan wants to merge 1 commit intobrowserbase:mainfrom
Open
fix: convert scroll_at direction/magnitude to scroll_x/scroll_y in GoogleCUAClient#263t-anjan wants to merge 1 commit intobrowserbase:mainfrom
t-anjan wants to merge 1 commit intobrowserbase:mainfrom
Conversation
…ogleCUAClient Previously, GoogleCUAClient._process_provider_response was passing the raw direction and magnitude fields from Google CUA's scroll_at function call directly into the ScrollAction payload. This caused Pydantic validation errors because ScrollAction expects scroll_x and scroll_y fields instead. This change: - Safely extracts direction and magnitude with defaults (down, 800) - Converts direction/magnitude to scroll_x/scroll_y values - Handles all four directions (up, down, left, right) with proper sign - Gracefully handles missing or non-numeric magnitude values - Removes the unsupported direction error path The fix now correctly produces ScrollAction payloads that validate and execute properly when scrolling in the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The GoogleCUAClient was failing to parse scroll actions from Google's CUA model. When Google returned a
scroll_atfunction call with{direction, magnitude}parameters, the client was passing these raw fields to the ScrollAction model, which expects{scroll_x, scroll_y}. This caused Pydantic validation errors and prevented scroll actions from working in the browser automation pipeline.What Changed
Test Plan
Summary by cubic
Fixes scroll parsing in GoogleCUAClient by converting Google’s scroll_at {direction, magnitude} to {scroll_x, scroll_y}. This resolves validation errors and makes scroll actions work in the browser.
Written for commit 59ef7cb. Summary will update on new commits.