Skip to content

fix: resolve all bun audit vulnerabilities with package overrides#338

Merged
Dani Akash (DaniAkash) merged 6 commits intomainfrom
claude/slack-fix-bun-vulnerabilities-5FddC
Mar 2, 2026
Merged

fix: resolve all bun audit vulnerabilities with package overrides#338
Dani Akash (DaniAkash) merged 6 commits intomainfrom
claude/slack-fix-bun-vulnerabilities-5FddC

Conversation

@DaniAkash
Copy link
Copy Markdown
Contributor

Add overrides for 8 vulnerable transitive dependencies: qs, markdown-it, lodash-es, @modelcontextprotocol/sdk, axios, diff, @isaacs/brace-expansion, and hono. This resolves 11 security vulnerabilities including DoS, ReDoS, prototype pollution, XSS, and data leak issues.

Add overrides for 8 vulnerable transitive dependencies: qs, markdown-it,
lodash-es, @modelcontextprotocol/sdk, axios, diff, @isaacs/brace-expansion,
and hono. This resolves 11 security vulnerabilities including DoS, ReDoS,
prototype pollution, XSS, and data leak issues.

https://claude.ai/code/session_01D3vmc2S4564FJSFqsRaTfM
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement.

To sign the CLA, please add a comment to this PR with the following text:

I have read the CLA Document and I hereby sign the CLA

You only need to sign once. After signing, this check will pass automatically.


Troubleshooting
  • Already signed but still failing? Comment recheck to trigger a re-verification.
  • Signed with a different email? Make sure your commit email matches your GitHub account email, or add your commit email to your GitHub account.
- - - I have read the CLA Document and I hereby sign the CLA - - - **1** out of **2** committers have signed the CLA.
✅ (DaniAkash)[https://github.com/DaniAkash]
Claude (@claude)
You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the **CLA Assistant Lite bot**.

@github-actions github-actions Bot added the fix label Feb 16, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 16, 2026

Greptile Summary

This PR addresses security vulnerabilities by adding package overrides for serialize-javascript (7.0.3) and lodash-es (4.17.23), and directly updating hono from ^4.6.0 to ^4.12.3 in both agent and server packages.

Key Changes:

  • Added serialize-javascript@7.0.3 override to fix vulnerabilities in transitive dependencies (used by webpack plugins)
  • Added lodash-es@4.17.23 override to fix prototype pollution vulnerabilities in transitive dependencies
  • Updated hono to 4.12.3 in both apps/agent and apps/server (minor version bump, compatible with existing semver ranges)

Note: The PR description mentions fixing 8 vulnerable packages, but only 3 packages are actually addressed in the final implementation. The initial approach attempted to override more packages, but these were removed (see commit 0b4a977) in favor of a more conservative approach. The diff override was specifically removed because it crossed a major version boundary and could break @google/gemini-cli-core compatibility.

Confidence Score: 4/5

  • This PR is safe to merge with low risk - only updates vulnerable dependencies without code changes
  • The overrides for serialize-javascript and lodash-es are patch/minor version upgrades that fix known security vulnerabilities. The hono update is a minor version bump (4.6.0 → 4.12.3) within the declared semver range, ensuring compatibility. The approach is conservative - the initial commit attempted to override 8 packages but was reduced to just 2 overrides + 1 direct update after removing problematic overrides (like diff which crossed major version boundary). Score is 4/5 rather than 5/5 due to the misleading PR description that doesn't match the final implementation.
  • No files require special attention - all changes are straightforward dependency version updates

Important Files Changed

Filename Overview
package.json Added overrides for serialize-javascript (7.0.3) and lodash-es (4.17.23) to fix security vulnerabilities in transitive dependencies
apps/agent/package.json Updated hono from ^4.6.0 to ^4.12.3 (minor version bump within semver range)
apps/server/package.json Updated hono from ^4.6.0 to ^4.12.3 (minor version bump within semver range)

Last reviewed commit: cf6ca77

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread package.json Outdated
@DaniAkash Dani Akash (DaniAkash) merged commit 80fe249 into main Mar 2, 2026
5 of 7 checks passed
@DaniAkash Dani Akash (DaniAkash) deleted the claude/slack-fix-bun-vulnerabilities-5FddC branch March 2, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants