Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
question,prompt,repair,witness,oracle) can live on the same local-first engine while preserving Memory Engine as the canonical default.Description
api/memory_engine/deployments.pywithmemoryas the default and planned sibling codes.ENGINE_DEPLOYMENTa first-class runtime setting inapi/memory_engine/settings.py, document it in.env.example, and validate it inapi/memory_engine/config_validation.pyso unknown values fail clearly.room_surface_config()inapi/engine/views.pyand to/api/v1/node/statusinapi/engine/api_views.py, and surface the active deployment label in the ops HTML template.kiosk-copy.jswithgetDeploymentPackand deployment overrides and switchingkiosk.jsto use the deployment-aware pack so Memory copy remains default whilequestion/repairplaceholders exist.docs/MISSION_EXPANSION.md,docs/DEPLOYMENT_BEHAVIORS.md, anddocs/RESPONSIVENESS.md, and updateREADME.md,docs/roadmap.md, anddocs/maintenance.mdto reflect the opening (explicitly stating this is an expansion, not a rebrand).frontend-tests/kiosk-copy.test.js), updatefrontend-tests/operator-dashboard.test.js, and extendapi/engine/tests/test_config.pyandapi/engine/tests/test_ops.pyto assert deployment catalog and node-status deployment payload behavior.Testing
npm run test:frontend(node-based frontend tests) and all frontend tests passed.python -m py_compileon modified modules) and they succeeded.validate_runtime_settings(...)smoke check (local script invocation) to verify deployment catalog + runtime shape and it passed.None); DB-backed tests therefore were not executed here.Codex Task