Allow wire to be started in spite of hover#17
Open
AmityWilder wants to merge 2 commits intobsiever:masterfrom
Open
Allow wire to be started in spite of hover#17AmityWilder wants to merge 2 commits intobsiever:masterfrom
AmityWilder wants to merge 2 commits intobsiever:masterfrom
Conversation
!selected.isEmpty() will always be true upon adding the wireEnd to the selection. It also fails to capture the intent, which is that if there WAS a selection, there are elements that are likely overlapping. If there was no selection, there are likely no elements overlapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires are allowed to be connected to other wires and are allowed to overlap other elements before being confirmed. However, the wire creation action validates against this by refusing to create a wire if an element is currently hovered.
This makes wire construction a little unwieldy since it can only be performed over an empty grid space, which there may be few of on a dense circuit. I believe it would be ideal if the only limiting factors for initiating wire creation were the same limiting factors present during wire creation.
i.e. if you could do it after pressing ctrl+w, it should be allowed while pressing ctrl+w. That would be more intuitive, consistent, and ergonomic.