Fix node6 native #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Whoops I had just run into this a couple days ago and fixed it, and published to npm (1.1.0) but forgot to push to GitHub! The relevant fix is mostly https://github.com/nickb1080/intercept-require/blob/master/lib/index.js#L124 Does this fix satisfy your issue? I've pulled your test case in and it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intercept fails for native modules in node6. In that case. absPath remains undefined, which causes path.extname to fail in node 6, as it no longer accepts undefined.
The behavior of path.extname in node 4 when undefined is passed in is to return an empty string, so the fix is to check for undefined and return an empty string directly if it is.
These are the relevant lines: https://github.com/nickb1080/intercept-require/blob/master/lib/index.js#L108-L130
The error is easy to reproduce, use n to easily switch between node versions. I added a test as well. To reproduce, first merge my first commit, run the test under node 6 and see it fail. Then merge the second commit and see it pass.