fix: set workerName, instanceName for worker profile and pipeline cha…#19
Open
jasonschroeder-sfdc wants to merge 8 commits intobuildfarm:masterfrom
Open
fix: set workerName, instanceName for worker profile and pipeline cha…#19jasonschroeder-sfdc wants to merge 8 commits intobuildfarm:masterfrom
jasonschroeder-sfdc wants to merge 8 commits intobuildfarm:masterfrom
Conversation
werkt
reviewed
Nov 26, 2025
| c := bfpb.NewWorkerControlClient(conn) | ||
| r, err := c.PipelineChange(context.Background(), &bfpb.WorkerPipelineChangeRequest{}) | ||
| r, err := c.PipelineChange(context.Background(), &bfpb.WorkerPipelineChangeRequest{ | ||
| InstanceName: "shard", |
Member
There was a problem hiding this comment.
The instance name is set in the app context: https://github.com/buildfarm/bf-client/blob/master/client/app.go#L19
Bumping dependency
There is no `test.go`
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nge requests