mci 0 will result a out-of-memory by div 10 always true#45
Open
dindinw wants to merge 2 commits intobyteball:masterfrom
Open
mci 0 will result a out-of-memory by div 10 always true#45dindinw wants to merge 2 commits intobyteball:masterfrom
dindinw wants to merge 2 commits intobyteball:masterfrom
Conversation
Member
|
Can it be called with mci=0 at all? |
Author
|
not at the current stage, because mc=0 is no sense, but I think it maybe be better & safer for the method to check the input argument. anyway I result a Out-of-memory when I was doing my test. |
| @@ -916,6 +916,7 @@ function markMcIndexStable(conn, mci, onDone){ | |||
| function getSimilarMcis(mci){ | |||
There was a problem hiding this comment.
@dindinw what do you think of rewriting the whole function as
function getSimilarMcis(mci){
var arrSimilarMcis = [];
if (mci <= 0)
return arrSimilarMcis;
var divisor = 10;
while (mci % divisor === 0) {
arrSimilarMcis.push(mci - divisor);
divisor *= 10;
}
return arrSimilarMcis;
}
dindinw
commented
Oct 17, 2017
| @@ -916,6 +916,7 @@ function markMcIndexStable(conn, mci, onDone){ | |||
| function getSimilarMcis(mci){ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.