fix(bindgen): futures and stream are not Clone#12155
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 13, 2026
Merged
fix(bindgen): futures and stream are not Clone#12155alexcrichton merged 1 commit intobytecodealliance:mainfrom
Clone#12155alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Could you add a test for this as well?
I think it would be reasonable to add Clone too, but I think that might require some careful handling on the runtime side of things as I don't think it's quite ready for clone/copy just yet.
alexcrichton
approved these changes
Dec 13, 2025
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
fd91df6 to
d23e8e3
Compare
Member
Author
|
Sorry for the delay here, @alexcrichton I've expanded the |
alexcrichton
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this trying to generate bindings for an interface containing something like:
record test { rx: stream<u8>, tx: stream<u8>, }which failed with:
The change is fairly minimal and straightforward, so did not work on a test or anything like that.
I do not like this field name, but splitting into
has_futureandhas_streamwould require splitting also theTypeDefKindmatch cases (which are currently unified) and it did not quite feel right to include this inhas_handleeither.