sys/miri: fix Mmap::from_file to seek to start of file.#12572
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Feb 11, 2026
Merged
sys/miri: fix Mmap::from_file to seek to start of file.#12572cfallin merged 1 commit intobytecodealliance:mainfrom
Mmap::from_file to seek to start of file.#12572cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
The constructor takes a `&File` but `&File` still allows mutation of the underlying state, e.g., the seek position. It turns out that this matters when we try to `Mmap::from_file` more than once, e.g. when enabling guest debugging and thus mapping private copies of code. No test yet as this will be covered by upcoming miri coverage of guest debugging.
Member
Author
|
(Found while trying to add miri coverage to #12566) |
alexcrichton
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor takes a
&Filebut&Filestill allows mutation of the underlying state, e.g., the seek position. It turns out that this matters when we try toMmap::from_filemore than once, e.g. when enabling guest debugging and thus mapping private copies of code.No test yet as this will be covered by upcoming miri coverage of guest debugging.