Use our OOM-handling Vec in wasmtime_environ::Module

[fitzgen]

Depends on

• Refactor String usage in wasmtime_environ::Module #12565
• Add a vec! macro for our OOM-handling Vec #12581
• Allow slicing our OOM-handling Vec with ranges #12582
• Add truncate and resize methods to our OOM-handling Vec #12583

[alexcrichton]

Related, but not blocking thought on this: collections::Vec is a bummer. Bikeshedding: if we were to rename wasmtime_environ::collections::Vec, what would we rename it to?

• TryVec - perhaps accurate, but long. TryIndexMap is a lot.
• TVec - personally I kinda like the ring of "letter plus collection". It's short and clearly "not std"
• WVec - wasmtime's vec?
• XVec - any other random letter
• OomVec - I don't like this b/c the container handles OOMs, it doesn't make OOMs
• VecT (or VecW or such) - subjectively not a fan

WDYT about maybe putting "t" or "T" in front of all the collections? For example tvec![...] and TVec and THashMap? (or any other letter really)

[github-actions]

Subscribe to Label Action

cc @fitzgen

Details

This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

[fitzgen]

Related, but not blocking thought on this: collections::Vec is a bummer. Bikeshedding: if we were to rename wasmtime_environ::collections::Vec, what would we rename it to?

* `TryVec` - perhaps accurate, but long. `TryIndexMap` is a lot.

* `TVec` - personally I kinda like the ring of "letter plus collection". It's short and clearly "not `std`"

* `WVec` - wasmtime's vec?

* `XVec` - any other random letter

* `OomVec` - I don't like this b/c the container handles OOMs, it doesn't make OOMs

* `VecT` (or `VecW` or such) - subjectively not a fan

WDYT about maybe putting "t" or "T" in front of all the collections? For example tvec![...] and TVec and THashMap? (or any other letter really)

Yeah, I think something like this is inevitable if we aren't going to eventually move everything over to the OOM-handling versions.

I kind of hate all the potential names ~equally (no shade to you, they are basically the same candidates I've come up with myself).

I guess I like WVec the most maybe? Or if we are going to choose an arbitrary letter, might as well choose a cool one like XVec or something lol