RR #3:Flat type computation for interface types for RR#12981
Open
arjunr2 wants to merge 1 commit intobytecodealliance:mainfrom
Open
RR #3:Flat type computation for interface types for RR#12981arjunr2 wants to merge 1 commit intobytecodealliance:mainfrom
arjunr2 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
alexcrichton
reviewed
Apr 7, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
I think that the code here will end up duplicating some functionality elsewhere already in Wasmtime, especially around handling per-type flat ABIs. An example is that crates/environ/src/fact/signature.rs contains a lot of flattening already for function signatures, although not of the exact same shape and form of here. Notably as well TypeInformation already has various helpers and such to push in more flat information. Would it be possible to reuse/refactor the existing implementations instead of adding another?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides methods to compute the exact core wasm ABI encoding of param/result interface types for precise recording/replaying.