x64: Fix typo in splat lowering#12986
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
x64: Fix typo in splat lowering#12986alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
splat lowering#12986alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
An `Xmm` was explicitly created but never used. This didn't have much real consequence since a rule with `sinkable_load` had higher precedence, but this does affect a few tests which splat constants by making it a bit more optimal.
github-actions
bot
added
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
Xmmwas explicitly created but never used. This didn't have much real consequence since a rule withsinkable_loadhad higher precedence, but this does affect a few tests which splat constants by making it a bit more optimal.