fix: non-exhaustive pattern in is_connection_open on old Rust versions#42
Merged
5t0n3 merged 2 commits intocPacketNetworks:mainfrom Sep 11, 2024
5t0n3:non-exhaustive-read-check-fix
Merged
fix: non-exhaustive pattern in is_connection_open on old Rust versions#425t0n3 merged 2 commits intocPacketNetworks:mainfrom 5t0n3:non-exhaustive-read-check-fix
is_connection_open on old Rust versions#425t0n3 merged 2 commits intocPacketNetworks:mainfrom
5t0n3:non-exhaustive-read-check-fix
Conversation
Something changed in how the compiler determines whether all cases of a match were covered in 1.75, so using the range pattern broke building on 1.74.
ctrlaltf24
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39 broke compilation on Rust versions below 1.75 due to a match in
is_connection_open(), namely:tacacs-plus-rs/tacacs-plus/src/inner.rs
Lines 257 to 276 in 7a1164b
The behavior of matching
usizes against open ranges landed in rust-lang/rust#116692, which was first included in 1.75.0.To keep compatibility with older versions of Rust, this PR changes the range to an
_instead, which has the same behavior and unbreaks builds on older compilers.