⚡ Bolt: Optimize @Published array mutations to reduce UI recalculations#126
⚡ Bolt: Optimize @Published array mutations to reduce UI recalculations#126
Conversation
This commit replaces loop-based mutations of `@Published` arrays in `CacheoutViewModel` with functional `.map` methods to batch property updates and prevent excessive UI recalculations. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Refactored multiple methods in
CacheoutViewModel(selectAllSafe,deselectAll,selectStaleNodeModules,selectAllNodeModules,deselectAllNodeModules) to use.mapfor updating the@PublishedarraysscanResultsandnodeModulesItems, replacing the previousforloop index-based mutation.🎯 Why:
In SwiftUI, when a
@Publishedproperty is an array of value types (likeScanResultorNodeModulesItem), mutating individual elements inside a loop (e.g.,scanResults[i].isSelected = true) triggers theobjectWillChangepublisher for every single iteration. For lists with many items, this results in significant unnecessary work on the main thread as SwiftUI attempts to recalculate the view hierarchy repeatedly.📊 Impact:
By mapping over the array and assigning the modified array back to the property in a single operation, the publisher emits exactly once per function call. This drastically reduces CPU overhead and main thread blocking during bulk selection/deselection operations.
🔬 Measurement:
To verify, run the application, populate the lists with numerous items (e.g., node_modules folders), and observe the CPU usage or UI responsiveness when clicking "Select All" or "Deselect All". The UI update should be near-instantaneous with minimal main thread spikes compared to the previous implementation.
PR created automatically by Jules for task 7747625739575382867 started by @acebytes