Skip to content

🎨 Palette: Expand clickable area and improve accessibility for category rows#127

Open
acebytes wants to merge 1 commit intomainfrom
palette-ux-clickable-category-rows-4683801814068669321
Open

🎨 Palette: Expand clickable area and improve accessibility for category rows#127
acebytes wants to merge 1 commit intomainfrom
palette-ux-clickable-category-rows-4683801814068669321

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What
Wrapped the CategoryRow's HStack inside a Button with .contentShape(Rectangle()) to make the entire row clickable.

🎯 Why
Previously, only the small circular checkbox icon was clickable. This was a poor UX pattern that required precise mouse/trackpad positioning. By making the whole row clickable, users can easily select and deselect cache categories.

📸 Before/After
Before: Click target limited to a ~20x20px circle icon.
After: Click target expands to the full width and height of the row.

♿ Accessibility
Added .accessibilityElement(children: .combine) and .accessibilityAddTraits(result.isSelected ? .isSelected : []). This unifies the row's child text elements (name, description, size) into a single cohesive VoiceOver announcement and properly communicates the selected state.


PR created automatically by Jules for task 4683801814068669321 started by @acebytes

Wrap entire CategoryRow in a Button with contentShape(Rectangle()) to make the empty space clickable. Add accessibilityElement(children: .combine) and accessibilityAddTraits to improve VoiceOver experience.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant