🛡️ Sentinel: [security improvement] Refactor toolExists to use direct Process execution#128
🛡️ Sentinel: [security improvement] Refactor toolExists to use direct Process execution#128
Conversation
Replaced `toolExists` shell wrapper with a direct `Foundation.Process` execution of `/usr/bin/which` where `tool` is passed explicitly in the `arguments` array. Evaluates `process.terminationStatus == 0` after `process.waitUntilExit()`. Standard output/error is mapped to `FileHandle.nullDevice`. Also documented findings in .jules/sentinel.md. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR provides a defense-in-depth security enhancement to the
CacheCategory.toolExistsmethod. The previous implementation evaluated shell commands using string interpolation (shell("/usr/bin/which \(tool)")). Even though the inputs are statically defined, evaluating dynamic inputs using/bin/bash -cis an unsafe pattern that risks command injection. The code has been refactored to use a directFoundation.Processexecution of/usr/bin/which, passingtoolstrictly as an element in theargumentsarray and returning successfully whenterminationStatus == 0. We also mappedstandardOutputandstandardErrortoFileHandle.nullDeviceto prevent resource leaks.PR created automatically by Jules for task 14105587751512567198 started by @acebytes