Add display option to getAccounts bitcoin app#2
Open
ben-kaufman wants to merge 1 commit intocake-tech:trunkfrom
Open
Add display option to getAccounts bitcoin app#2ben-kaufman wants to merge 1 commit intocake-tech:trunkfrom
ben-kaufman wants to merge 1 commit intocake-tech:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the display option for displaying an address using getAccounts on the Ledger device. It is not reqquired and set to false by default to avoid impact on any existing usage.
Displaying an address on the Ledger is an important security feature, as it allows the user to ensure the address they see on their wallet app is controlled by their Ledger device, which is why exposing this option here is important.