Fix remaining method signature mismatches against CakePHP 5.x source #8216
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RouteBuilder::prefix/plugin are instance methods, not static - CacheEngine::write/read renamed to set/get per PSR-16 - Session methods use $name parameter, not $key - ServerRequest::addDetector parameter is $detector - Response: fix nullable types, union types, and parameter names for withStringBody, withCache, withExpires, withEtag, withModified, withVary, withHeader - ConsoleIo::ask has 2 params (not 3), createFile has $forceOverwrite - LogTrait::log accepts Stringable|string and $context param - newClientResponse is on HttpClientTrait, not Response
dereuromark
commented
Feb 1, 2026
| ### Prefix Routing | ||
|
|
||
| `static` Cake\\Routing\\RouteBuilder::**prefix**(string $name, Closure|array $params = [], ?Closure $callback = null): static | ||
| `method` Cake\\Routing\\RouteBuilder::**prefix**(string $name, Closure|array $params = [], ?Closure $callback = null): static |
Member
Author
There was a problem hiding this comment.
Is that correct? or do we keep static here?
Contributor
There was a problem hiding this comment.
well technically its still static but I do believe we now recommend using the routebuilder instance oriented way of writing this, so adjusting it to method seems fine by me.
josbeir
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8215. Fixes remaining signature mismatches verified against the CakePHP 5.x source code: