Skip to content

Document Number::parseFloat() returning null on failure #8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dereuromark wants to merge 1 commit into
base: 5.next
Choose a base branch
from
Draft

Document Number::parseFloat() returning null on failure #8250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/en/appendices/5-4-migration-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,16 @@ bin/cake upgrade rector --rules cakephp54 <path/to/app/src>

## Behavior Changes

- WIP
### I18n

``Number::parseFloat()`` now returns ``null`` instead of ``0.0`` when parsing
fails. Previously, when ``NumberFormatter::parse()`` failed it returned ``false``,
which was cast to ``0.0``. This silently converted invalid input like ``"abc"``
to ``0.0``, making it impossible to distinguish from valid ``"0"`` input.

This also affects ``FloatType`` and ``DecimalType`` database types which use
``Number::parseFloat()`` internally. Invalid locale-formatted form input will
now result in ``null`` entity values instead of ``0``.

## Deprecations

Expand Down
Loading