Skip to content

Install clang-format via GHA action instead of via NPM #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraenhansen merged 2 commits into from
Feb 1, 2026
+40 −21
Merged

Install clang-format via GHA action instead of via NPM #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c897e51
Install LLVM / clang-format on CI
kraenhansen Feb 1, 2026
88bcc1b
Prevent NPM from installing "clang-format"
kraenhansen Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
# Set up JDK and Android SDK only because we need weak-node-api, to build ferric-example and to run the linting
# TODO: Remove this once we have a way to run linting without building the native code
- name: Set up JDK 17
Expand Down Expand Up @@ -67,6 +71,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
Expand Down Expand Up @@ -96,6 +104,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- run: npm ci
- run: npm run build
- name: Prepare weak-node-api
Expand All @@ -115,6 +127,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -148,6 +164,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -179,6 +199,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
Expand Down Expand Up @@ -259,6 +283,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ jobs:
- uses: actions/setup-node@v6
with:
node-version: lts/krypton
- name: Setup clang-format
uses: aminya/setup-cpp@v1
with:
clang-format: true
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
Expand Down
26 changes: 5 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
"typescript": "^5.8.0",
"typescript-eslint": "^8.38.0"
},
"overrides": {
"clang-format": "npm:dry-uninstall"
},
"devEngines": {
"runtime": {
"name": "node",
Expand Down
Loading