Skip to content

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Feb 1, 2026

I see failures building for MacOS here: https://github.com/callstackincubator/react-native-node-api/actions/runs/21562769725/job/62133783654

⚭ Linked ../node-addon-examples/tests/async/build/RelWithDebInfo/addon.apple.node → async-test--addon.xcframework
✖ Failed to copy ../node-addon-examples/tests/buffers/build/RelWithDebInfo/addon.apple.node
Running 'install_name_tool' failed (code = 1)
error: /Applications/Xcode_16.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: addon (for architecture arm64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

Merging this PR will:

  • Pass the -headerpad_max_install_names argument to the linker to increase the padding of the header to allow updating the install name of library files when linking them into the app.
  • Add weak-node-api as a dependency to the "MacOS test app" (missed this in Separate weak-node-api package #308).

@kraenhansen kraenhansen added CI Continuous integration Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) CMake RN Our `cmake` wrapping CLI MacOS 💻 Anything related to the Apple MacOS platform or React Native MacOS support labels Feb 1, 2026
@kraenhansen kraenhansen changed the title Pass headerpad_max_install_names to linker Pass headerpad_max_install_names to linker Feb 1, 2026
@kraenhansen kraenhansen self-assigned this Feb 1, 2026
@kraenhansen kraenhansen merged commit d43350e into main Feb 1, 2026
17 of 18 checks passed
@kraenhansen kraenhansen deleted the kh/headerpad-linker-argument branch February 1, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) CI Continuous integration CMake RN Our `cmake` wrapping CLI MacOS 💻 Anything related to the Apple MacOS platform or React Native MacOS support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants