Open
Conversation
Adds validation for xcodebuild extraArgs to prevent invalid options. Co-authored-by: cameron.cooke <cameron.cooke@sentry.io>
Contributor
Author
|
Cursor Agent can help with this pull request. Just |
commit: |
|
This PR has been inactive for 21 days. It will be closed in 7 days if no further activity occurs. Add a comment to keep it open, or apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for
xcodebuildextraArgsto prevent failures from invalid options.The
xcodebuildcommand fails when users pass unrecognized options like-test-argviaextraArgs. This PR introduces a validation step that checks for such invalid arguments and provides a clear error message, guiding users to use thetestRunnerEnvparameter for passing environment variables to the test runner instead.Note
Adds a guard to prevent invalid
xcodebuildflags that cause test runs to fail.utils/xcodebuild-validation.tswithvalidateXcodebuildExtraArgsto detect invalid options (e.g.,-test-arg) and return a clear, actionable error pointing totestRunnerEnvtest_device,test_macos, andtest_simlogic before invokingxcodebuildutils/__tests__/xcodebuild-validation.test.tsand new validation cases insimulator/__tests__/test_sim.test.ts(exportingtest_simLogic, usingcreateMockExecutor)Written by Cursor Bugbot for commit 6da6db7. This will update automatically on new commits. Configure here.