Open
Conversation
add keys, vals, keysRev and valsRev
Update StableRBTree.mo
* main: Add scanLimit (adapted from CanDB RangeTree) and tests Add update() function, make bal method public so it can be reused by other libraries * Add in Motoko matchers tests for the update() function # Conflicts: # src/StableRBTree.mo
Author
|
done |
Author
|
Shoot...I'm on the wrong repo😂 Sorry for messing with your stuff. |
Contributor
|
@skilesare sorry for the delayed response, and no worries! I think the keys() and vals() makes for a nice addition - the only issue I worry about in terms of adding it is unbounded iteration (with no limit) hitting the message instruction limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.