Open
Conversation
Author
|
Any chance of getting this merged or is there a philosophical reason to not do this? Happy to go another route and/or eliminate the pull request @mreinstein Thanks! |
Contributor
|
I would love to see this PR merged. We have had to do some massive hacks to get similar behavior in our tests. My guess is that because this project is not active any more, there is no one available who can spend time reviewing this PR. So, I'll review it myself, even though I am not a committer on this project. Maybe we can push this forward. Some suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module teardown to allow closing out connection pools, etc so that nodeunit exit expeditiously after running tests